Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry pick 6.3] Include gfx12 and gfx1151 in default architecutre list for rmake.py #638

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[cherry pick 6.3] Include gfx12 and gfx1151 in default architecutre list for rmake.py #638

merged 4 commits into from
Nov 13, 2024

Conversation

NguyenNhuDi
Copy link
Collaborator

No description provided.

umfranzw
umfranzw approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The CI failures don't look like they are related to the change.

@umfranzw umfranzw self-requested a review November 12, 2024 19:19
spolifroni-amd
spolifroni-amd requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one issue that needs to be addressed.

CHANGELOG.md Outdated Show resolved Hide resolved
@NguyenNhuDi @spolifroni-amd
Update CHANGELOG.md
85fcaa9 
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
@vamovsik vamovsik merged commit 84efac2 into ROCm:release/rocm-rel-6.3 Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolifroni-amd spolifroni-amd spolifroni-amd approved these changes

@umfranzw umfranzw umfranzw approved these changes

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NguyenNhuDi @umfranzw @spolifroni-amd @vamovsik