Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocWMMA Utilities #341

Merged
merged 25 commits into from
Feb 20, 2024
Merged

rocWMMA Utilities #341

merged 25 commits into from
Feb 20, 2024

Conversation

dlangbe
Copy link
Contributor

@dlangbe dlangbe commented Feb 6, 2024

Moves common utilities to `rocwmma/internal/utility'. The following utilities have been added to the rocWMMA namespace with drop-in replacements enabled for hipRTC compilation:

  • get.hpp: std::get replacement with overloads for internal vector types
  • `forward.hpp': std::forward replacement
  • 'sequence.hpp': index sequence utilities
  • 'vector.hpp': vector utilites
  • `type_traits.hpp': drop-in replacements for many meta programming types for hipRTC compliance

dlangbe and others added 21 commits January 12, 2024 17:51
get impl
0d6fabb
@cgmillette
Adjust get interface
e905244
@cgmillette
Adjust forward utility
409a48f
@cgmillette
Add utility type traits
5ffbfdc
@cgmillette
Fixup hipRTC errors on type_traits
f2ae0a4
@cgmillette
Fix clash of is_same function with is_same class
38591bd
forward util
4a50112
@cgmillette
Remove explicit std namespace scoping for forward, get, decay, is_sam…
fdca1e1 
…e and other type traits
@dlangbe
Merge branch 'utils' into utils-move
c11aa6a
@dlangbe
Merge pull request #4 from dlangbe/utils-move
cb0972b 
Utils move
Changes to numeric_limits
2364a87
type traits cleanup
e9b9f6b
sequence restructuring
6b8e358
@cgmillette
Initial commit aos_soa block dim 16, 32, 64, 128
ba054b1
@cgmillette
Refactor vector ordering utilities into separate file. Optimize sub-d…
1405e6c 
…word vector re-ordering.
@cgmillette
Add unit tests for vector util
bc07292
@cgmillette
Add unit test for pack util
358263a
@cgmillette
Refactor vector_util interface. Add unit tests
a5d56f6
@cgmillette
Fix pack util bugs
3aad1d1
@cgmillette
Update vector util description with 4 element examples
72c0a4e
vector utilities
ec586dd
cgmillette
cgmillette approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, LGTM. Please address the no newline at the end of files, and make sure that hipRTC sample builds / runs.

@dlangbe dlangbe merged commit 69694c8 into ROCm:develop Feb 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmillette cgmillette cgmillette approved these changes

@CongMa13 CongMa13 Awaiting requested review from CongMa13 CongMa13 is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@mkarunan mkarunan Awaiting requested review from mkarunan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlangbe @cgmillette