Correct path for ROCMConfig redirect #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgmb
reviewed
Jan 5, 2024
|
Note that the failures on macOS are likely unrelated, as the develop branch is also failing on macOS, which should be investigated. |
cgmb
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous redirect in ROCMConfig.cmake did not correctly specify the path to ROCmCMakeBuildTools. This caused failures if the user only specified the path to ROCM, (via something like
ROCM_DIR), as there were then no correct paths to search for ROCmCMakeBuildTools. I want to create a test for this, but I'm not quite sure how yet, it's in progress.