Header-only devel package PROVIDES field fixes #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code for provides field was not evaluating the CPACK_DEBIAN_PACKAGE_PROVIDES variable, causing CPACK_DEBIAN_PACKAGE_PROVIDES to be included as a literal string provided by the devel package.
lawruble13
force-pushed
the
devel-provides-fix
branch
from
fea3a99
to
17d3d72
Compare
cgmb
approved these changes
Aug 29, 2024
lawruble13
added a commit
to lawruble13/rocm-cmake
that referenced
this pull request
Sep 6, 2024
* Fix provides field Previously the code for provides field was not evaluating the CPACK_DEBIAN_PACKAGE_PROVIDES variable, causing CPACK_DEBIAN_PACKAGE_PROVIDES to be included as a literal string provided by the devel package. * Correct debian/rpm * Fix misplaced comma * Remove version from RPM provides field --------- Co-authored-by: Eiden Yoshida <47196116+eidenyoshida@users.noreply.github.com>
lawruble13
added a commit
to lawruble13/rocm-cmake
that referenced
this pull request
Sep 6, 2024
* Fix provides field Previously the code for provides field was not evaluating the CPACK_DEBIAN_PACKAGE_PROVIDES variable, causing CPACK_DEBIAN_PACKAGE_PROVIDES to be included as a literal string provided by the devel package. * Correct debian/rpm * Fix misplaced comma * Remove version from RPM provides field --------- Co-authored-by: Eiden Yoshida <47196116+eidenyoshida@users.noreply.github.com> (cherry picked from commit d27d809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPACK_DEBIAN_PACKAGE_PROVIDESwas not evaluated, causing packages to include the literal stringCPACK_DEBIAN_PACKAGE_PROVIDESin their provides field.CPACK_<GEN>_PACKAGE_PROVIDESonly if a component-specific variable is not set.-dev[el]is added in either case.