Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(projects.yaml): Update omniperf and omnitrace dev branch #885

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix(projects.yaml): Update omniperf and omnitrace dev branch #885

merged 3 commits into from
Oct 18, 2024

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Jul 30, 2024 •
edited
Loading

Depends on
ROCm/omnitrace#367
ROCm/rocprofiler-compute#389

Do not merge this PR until the above two are merged

@samjwu samjwu self-assigned this Jul 30, 2024
@samjwu samjwu marked this pull request as ready for review August 1, 2024 21:16
@samjwu samjwu requested a review from a team August 1, 2024 21:20
@samjwu samjwu marked this pull request as draft August 1, 2024 22:51
yhuiYH
yhuiYH approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@yhuiYH yhuiYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an approval for the branch rename. Merge when the others PRs are in.

@samjwu
Copy link
Member Author

samjwu commented Aug 9, 2024

omniperf rename done. pending omnitrace

@samjwu samjwu marked this pull request as ready for review October 2, 2024 22:42
@samjwu samjwu merged commit 9e452cb into ROCm:develop Oct 18, 2024
7 checks passed
@samjwu samjwu deleted the omniproj branch October 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuiYH yhuiYH yhuiYH approved these changes

Assignees

@samjwu samjwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samjwu @yhuiYH