Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check /sys/module/amdgpu for ROCk instead of lsmod #104

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Check /sys/module/amdgpu for ROCk instead of lsmod #104

wants to merge 1 commit into from

Conversation

littlewu2508
Copy link

Closes: #102

Signed-off-by: YiyangWu xgreenlandforwyy@gmail.com

keryell
keryell requested changes May 27, 2022
View reviewed changes
Copy link

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification.
But then I think you could just use Python code to test for the file existence instead of forking a shell.

@littlewu2508 littlewu2508 changed the base branch from master to develop January 1, 2024 09:33
@littlewu2508
Just check /sys/module/amdgpu if initstate not present
fe96886 
In case amdgpu is builtin

Closes: ROCm#102

Signed-off-by: YiyangWu <xgreenlandforwyy@gmail.com>
@LtdJorge
Copy link

LtdJorge commented Aug 5, 2024

Could this be reconsidered? I had to patch my rocm-smi because I'm building amdgpu into the kernel, but it works fine without that.

LtdJorge added a commit to LtdJorge/rocm_smi_lib that referenced this pull request Aug 5, 2024
@LtdJorge
Updates driverInitialized() to support amdgpu built as module as well…
0ab16c2 
… as kernel built-in. Fixes ROCm#102 and is an updated version of ROCm#104
@LtdJorge LtdJorge mentioned this pull request Aug 5, 2024
Open
@LtdJorge
Copy link

LtdJorge commented Aug 5, 2024

I opened #189 to address what @keryell mentioned. The new PR also does away with driverInitialized being a string, checking its length and then returning a bool. driverInitialized is now a bool and is returned directly.

@LtdJorge LtdJorge mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell requested changes

@dmitrii-galantsev dmitrii-galantsev Awaiting requested review from dmitrii-galantsev dmitrii-galantsev is a code owner

@charis-poag-amd charis-poag-amd Awaiting requested review from charis-poag-amd charis-poag-amd is a code owner

@oliveiradan oliveiradan Awaiting requested review from oliveiradan oliveiradan is a code owner

@bill-shuzhou-liu bill-shuzhou-liu Awaiting requested review from bill-shuzhou-liu bill-shuzhou-liu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

driverInitialized check not valid
3 participants
@littlewu2508 @LtdJorge @keryell