Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(E712): fix comparison to True/False #173

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from

Conversation

e-kwsm
Copy link

@e-kwsm e-kwsm commented May 26, 2024

from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):

Comparisons to singletons like None should always be done with is or is not, never the equality operators.

@dmitrii-galantsev
Copy link
Collaborator

@e-kwsm Do you have a suggestion on what linter to use for python?

Also - we would appreciate your effort spent on https://github.com/ROCm/amdsmi instead :)
That project is supposed to replace rocm-smi.

@e-kwsm
Copy link
Author

e-kwsm commented May 31, 2024

ROCm/amdsmi#35 opened.

@dmitrii-galantsev dmitrii-galantsev changed the base branch from develop to amd-staging July 8, 2024 16:37
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):

> Comparisons to singletons like None should always be done with is or is not, never the equality operators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants