Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajanicijamd/omnitrace build error fix #15

Conversation

ajanicijamd
Copy link
Contributor

Installed library paths changed from hard-coded lib to directory resolved from CMAKE_INSTALL_LIBDIR.

@jrmadsen
Copy link
Collaborator

Idk why these changes are being made but basically none of this looks right. All of the instances where you are changing lib to CMAKE_INSTALL_LIBDIR appear to be related to the submodules which are built via autotools, which has no concept of CMAKE_INSTALL_LIBDIR. Furthermore, none of the static libraries are even actually installed when Omnitrace is installed, which is purpose of using CMAKE_INSTALL_LIBDIR.

@jrmadsen
Copy link
Collaborator

Also, we have a ROCm/timemory that will be used, not your fork.

@ajanicijamd
Copy link
Contributor Author

The problem that I am trying to solve is that on some hosts those modules built with autotools are installed under lib64 and not under lib, so I am hitting an error like this:

gmake[2]: *** No rule to make target 'external/elfutils/lib/libdw.a', needed by 'lib/librocprof-sys.so.0.1.0'.  Stop.
gmake[1]: *** [CMakeFiles/Makefile2:6390: source/lib/rocprof-sys/CMakeFiles/rocprofiler-systems-shared-library.dir/all] Error 2
gmake: *** [Makefile:166: all] Error 2

but libdw.a is in

external/elfutils/lib64/libdw.a

My solution is to find all such paths in CMake scripts and replace lib with ${CMAKE_INSTALL_LIBDIR} so when linking is performed, the actual path can be customized to contain lib64 and not lib. I am open to suggestions for a better solution.

@ajanicijamd ajanicijamd closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants