RPP Rain augmentation on HOST and HIP #463
Draft
+1,814
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Oct 23, 2024
•
r-abishek
commented
- Updates version to RPP 1.9.8
- Adds a dash-cam rain augmentation on HOST and HIP
- Adds support for U8/F16/F32/I8 bit depths with NCHW/NHWC tensor support
- Adds relevant unit/perf tests
Add F32 and F16 Tensor Implementation
code cleanup
RPP Rain Tensor
rrawther
reviewed
Nov 15, 2024
utilities/test_suite/HIP/runTests.py
Outdated
| @@ -478,7 +478,7 @@ def rpp_test_suite_parser_and_validator(): | |||
| print_performance_tests_summary(logFile, functionalityGroupList, numRuns) | |||
|
|
|||
| # print the results of qa tests | |||
| nonQACaseList = ['6', '8', '24', '54', '84'] # Add cases present in supportedCaseList, but without QA support | |||
There was a problem hiding this comment.
does this also has precision difference? why is this not added for QA?
rrawther
reviewed
Nov 15, 2024
| @@ -67,7 +67,7 @@ int main(int argc, char **argv) | |||
| bool additionalParamCase = (testCase == 8 || testCase == 21 || testCase == 23 || testCase == 24 || testCase == 49 || testCase == 79); | |||
| bool kernelSizeCase = (testCase == 49); | |||
| bool dualInputCase = (testCase == 2 || testCase == 30 || testCase == 33 || testCase == 61 || testCase == 63 || testCase == 65 || testCase == 68); | |||
| bool randomOutputCase = (testCase == 6 || testCase == 8 || testCase == 84); | |||
There was a problem hiding this comment.
I have commented many times before. We should not use numbers for test cases. It is better to use ENUMs here
rrawther
reviewed
Nov 15, 2024
| @@ -260,7 +260,7 @@ def rpp_test_suite_parser_and_validator(): | |||
| subprocess.call(["make", "-j16"], cwd=".") # nosec | |||
|
|
|||
| # List of cases supported | |||
| supportedCaseList = ['0', '1', '2', '4', '5', '6', '8', '13', '20', '21', '23', '26', '29', '30', '31', '32', '33', '34', '35', '36', '37', '38', '39', '45', '46', '49', '54', '61', '63', '65', '68', '70', '79', '80', '81', '82', '83', '84', '85', '86', '87', '88', '89', '90', '91', '92'] | |||
There was a problem hiding this comment.
same as before. Need to change numbers to ENUMs
rrawther
reviewed
Nov 15, 2024
| @@ -154,4 +154,4 @@ inline void read_bin_file(string refFile, T *binaryContent) | |||
| fseek(fp, 0, SEEK_SET); | |||
| fread(binaryContent, fsize, 1, fp); | |||
| fclose(fp); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
please revert this file as there seems to be no change
rrawther
requested changes
Nov 15, 2024
spolifroni-amd
requested changes
Dec 2, 2024
CHANGELOG.md
Outdated
| @@ -2,9 +2,16 @@ | |||
|
|
|||
| Full documentation for RPP is available at [https://rocm.docs.amd.com/projects/rpp/en/latest](https://rocm.docs.amd.com/projects/rpp/en/latest) | |||
|
|
|||
| ## (Unreleased) RPP 1.9.8 | |||
|
|
|||
| ### Changes | |||
There was a problem hiding this comment.
Suggested change
| ### Changes | |
| ### Changed |
CHANGELOG.md
Outdated
| ## (Unreleased) RPP 1.9.4 | ||
|
|
||
| ### Changes | ||
|
|
There was a problem hiding this comment.
Is this also unreleased? Because 1.9.8 is unreleased.
|
@r-abishek - needs conflicts resolved |
RPP Rain - Resolved Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.