-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tensor tests for clarity #469
Draft
r-abishek
wants to merge
9
commits into
ROCm:develop
Choose a base branch
from
r-abishek:ar/test_suite_mods_7
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+61
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Nov 4, 2024
- Rename Tensor_host tests to Tensor_image_host, and rename Tensor_hip tests to Tensor_image_hip to clarify the type of data for that subcategory of tests.
- This matches other test suite naming convention like in 'Tensor_voxel_host' or 'Tensor_audio_host' or 'Tensor_misc_host'.
rrawther
approved these changes
Nov 20, 2024
LakshmiKumar23
approved these changes
Nov 20, 2024
@r-abishek - conflicts needs resolved |
spolifroni-amd
approved these changes
Dec 2, 2024
@r-abishek can you fix the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.