Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays: message queue exceeds VK_OVERLAY_MAX_DRAW_CALLS #13270

Closed
Megamouse opened this issue Jan 22, 2023 · 2 comments · Fixed by #13333
Closed

Overlays: message queue exceeds VK_OVERLAY_MAX_DRAW_CALLS #13270

Megamouse opened this issue Jan 22, 2023 · 2 comments · Fixed by #13333
Assignees

Comments

@Megamouse
Copy link
Contributor

The emulator crashes when you push an unreasonable heap of messages into the overlay message queue.
This is probably happening because we immediately try to render them on screen, even when they are offscreen anyway.

So my suggestion is to keep them queued in memory until they can actually be displayed and also restrict the visible items to a fixed number.

We can also just drop duplicate messages that are still waiting, or simply refresh a visible message somehow.

@elad335
Copy link
Contributor

elad335 commented Jan 22, 2023

All mesaages can be ref-counted and disabled manually now, the logic can be applied externally.

@kd-11
Copy link
Contributor

kd-11 commented Jan 22, 2023

The logic should be handled by the overlay to display a reasonable number of messages on screen. The error thrown is just the backend refusing to issue thousands of draw calls to draw a simple UI as it is a sign that something has gone wrong.
I recommend a buffered queue with only 3 visible messages at a time.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants