Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx/overlays: Reimplement message queue #13333

Merged
merged 24 commits into from
Feb 3, 2023
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Feb 2, 2023

Bunch of changes, both functional and aesthetic.

  1. I had some code lying around for rounded rects, I made the overlay messages use this as well now before adding to other parts.
  2. Implement message stacking. Don't display the same message multiple times.
  3. Add both top pinned and bottom pinned notifications. Each set can display upto 3 simultaneous notifications. Notifications can be multiline as well without overlap issues.
  4. Removes the shader compilation notification and replaces it with a notification message.
  5. Add support for animated icons to the overlay system.
  6. Add an animated icon to the shader compilation notification instead of the janky dots. Animation was done in gimp and exported and there is full support for sprite animation now in the UI. If someone has a better sprite-set, I can use it instead.
  7. Messages have a seperate fade-in and fade-out animation as well. Makes messages spawning in less janky.

Some screenshots:
image
image
image

Known issues:

  • Rounded edges with small radius look a bit janky due to some issues with shading. The meshes are generated correctly though, it's a polygon filling issue afaict.

Fixes #13270

@kd-11
Copy link
Contributor Author

kd-11 commented Feb 2, 2023

Linux build is borked, I'll have to check it tomorrow.

Copy link
Contributor

@Megamouse Megamouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that the upper margin of the text is always bigger.
I noticed this in my settings branch. I don't remember if i just added some offset or fixed it otherwise though.

rpcs3/Emu/RSX/Overlays/overlay_animated_icon.h Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_animated_icon.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_animated_icon.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_animated_icon.h Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_message.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_message.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_message.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_message.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/Overlays/overlay_message.cpp Outdated Show resolved Hide resolved
@kd-11 kd-11 merged commit 262ecda into RPCS3:master Feb 3, 2023
@kd-11 kd-11 deleted the message-queue branch February 3, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlays: message queue exceeds VK_OVERLAY_MAX_DRAW_CALLS
2 participants