Savestates #10478

elad335 · 2021-06-19T21:31:51Z

Restrictions (most will be lifted as this work progresses):

Select libvdec.sprx in firmware libraries setting. (advanced tab) (well now it simply won't allow saving if HLE libvdec data is loaded in the background)
WCB+force CPU blit may improve compatibility.
PSN/Network - Offline.

Don't savestate while a message/save dialog is shown.

Do not save when the game itself is saving or installing game data (applies to disc games).
Do not delete or move game files.
Do not erase /dev_hdd1 contents.
Sharing savestates between people is not supported.
Do not HLE lwmutex or firmware libraries that aren't HLE'd by default. (the opposite is allowed as long as it's compatible with the game)

How to savestate

Ctrl+S savestates, savestate will be bootable from the game context menu later.

Versioning System

Because RPCS3 is one of the most complex emulators ever made (if not the most complex) and it is still in rapid development state, the need to update the emulation every now and then in a way which will affect savestates is inevitable.
So, while the rest of the emulators use a global version for their savestate for all components of the emulation, RPCS3 savestates will work in a smarter way which allows both rapid development of the emulation and high compatibility of old savestates.
The following actions has been taken:

Individual components of the emulation will use individual pair of "current" version and "supported" versions: what this means?
"supported" versions are versions listed which are known to be compatible with current RPCS3 build. Code can support more than one version at a time! how? this is where "current" version kicks in, the "current" version is read from the savestate file itself and by its value the code knows how to use the savestates file.
Not all emulation components are being used all the time. When updating the emulation for let's say X component, savestates which do not make use of this X component will still be compatible. (take for example PSN features)
In case the component is unused, its version won't even be saved to the savestate file!

Savestates modes (config.yml exclusives at the moment)

"Start Paused": When true, the emulation will be paused after first frame is being rendered. (note that this actually runs the emulation up to the next frame for it only then pauses it)
This setting is currently off by default but let me know if you want it on by default!
"Suspend Emulation Savestate Mode": Savestates use does not have to enforce cheating-alike attidude! When this mode is on, emulation exits when saving and the savestate file is deleted after loading it. This mode is like hibernation of emulation, if you don't want your exprience of hard games to be ruined by savestates, consider use this mode! This mode is extremely size-efficient because HDD1 is not saved. (filesystem state is assumed to not change in this mode)
Experimental and unused yet: "Inspection Mode Savestates": This mode is meant for debugging, it allows the saved savestate to be loaded without any game files in order to view the threads/memory state. It will not allow starting the emulation from that point.

Additional TODO list: (besides lifting restrictions)

Multi-savestates slots, currently each game ID has only one savestate slot at path rpcs3/savestates/[TITLE ID].SAVESTAT
If you want to simulate multiple slots, you can move and restore the savestate file at that path, or you can load savestate files directly via main RPCS3 context menu.

Fixes #4218

elad335 · 2021-06-20T08:12:00Z

Please test extensively this and report issues with logs. Also if you can get callstack for crashes I'll be glad. Issues remain unreported may persist after the pull requerst has been merged so please report them!

elad335 · 2021-06-20T08:17:15Z

Also feedback about reqeusted features is more than welcome!

elad335 · 2021-06-20T08:24:54Z

Also: before you are saving state, pause the emulation, go to kernel explorer and capture its contents. This really helps with debugging!
Utilities -> Kernel Explorer

elad335 · 2021-06-20T08:48:40Z

I just made kernel explorer always expand its entries and made it larger for ease of capture. (shared memory and lwmutex you can leave uncaptured if they are too large)

elad335 · 2021-06-20T08:59:28Z

I recommend capturing kernel explorer in video at 1fps so its contents can be easily read.

Satan86 · 2021-06-20T10:53:19Z

GT5 - Saved state, game continued playing fine. Finished the race I was currently on and moved on to the next in a different track, where it desynced. Loaded the savestate I had done in the previous race and the emulator crashed.
Log: RPCS3.zip
Savestate file: https://drive.google.com/file/d/1oRKGorzNktKDKo63RyLW8SDeqXWAmWMK/view?usp=sharing

Motorstorm - After saving state, the game crashed when reloading.
Log: RPCS3.zip
Savestate file: https://drive.google.com/file/d/1OeLsJzNTxjyfK9e3Q-gawIsgLEkxa-pj/view?usp=sharing

Motorstorm Apocalypse - Saved state, when the game finished reloading the entire emulator closed.
Log (last run): RPCS3.zip
Savestate file: https://drive.google.com/file/d/1Ziw7z9eAts_wjO4KPBk8clCH9S9vEknb/view?usp=sharing

Ridge Racer 7 - Saved state, when the game finished reloading it threw a fatal error.
Log: RPCS3.zip
Savestate file: https://drive.google.com/file/d/1HykRMEDZfTf5JXqpsdSmZnzDikdVy7t8/view?usp=sharing

Gran Turismo HD Concept - This game never worked in any savestate version, still a white screen when when reloading the game after saving state. Resuming the game after pausing freezes it, so the kernel explorer video was captured with the game running.
Log: RPCS3.log.gz
Savestate file: https://drive.google.com/file/d/1Sz-ZJ6INCs8n_bcPuKrrZFrnT6-_J0KW/view?usp=sharing
Kernel Explorer video:

2021-06-20.10-28-55.mp4

Skate 3 - Saved state, when the game finished reloading it threw a fatal error.
Log: RPCS3.zip
Savestate file: https://drive.google.com/file/d/197Mo_Xmpw7uRpw8yEHQ_1_ZZBK7KNiTF/view?usp=sharing
Kernel explorer video:

2021-06-20.10-47-03.mp4

God of War 3 - Everything seems to work fine, except performance took a hit after saving state, lost about 5 FPS.
Log (tested Heavenly Sword on the same run so it's also logged, it worked fine): RPCS3.zip
Savestate file: https://drive.google.com/file/d/1sKvunZp9ng7J5846626FMnwK0BHL7MEB/view?usp=sharing
Kernel Explorer video:

2021-06-20.11-14-02.mp4

The Last Of Us - Saved state, when the game finished reloading it threw a fatal error.
Log: RPCS3.log.gz
Savestate file: https://drive.google.com/file/d/1DlK6FvfHXuLMBJCJfW9FJHIQr-JjcqdJ/view?usp=sharing
Kernel Explorer video:

2021-06-20.11-33-27.mp4

I could get kernel explorer clips for the first few later if needed, they were tested before your latest commits

ChrisNonyminus · 2021-06-20T13:00:52Z

Grand Theft Auto IV (NPUB30702) crashes rpcs3 when loading states.
Tested on the opening of the game.
Log: RPCS3.log
Savestate File: https://drive.google.com/file/d/1b8aKQRzu-K8Hy8Qlb7giTgQw9kZvFayy/view?usp=sharing
Like a dummy, I forgot to record the kernel explorer before saving the state, so unfortunately I can't show any video of it because there is none.

Fallout New Vegas (BLUS30500) freezes when loading states.
Tested on the opening of the game, in-game, where you wake up in Doc Mitchell's house.
Log: RPCS3.log
Savestate File: https://drive.google.com/file/d/1406Zk_Bp9C6snGUH0qP-J0qD0usuTKZz/view?usp=sharing
Turns out RPCS3 crashes when starting the kernel explorer (for this game, at least), so I could record it for this, either.

ChrisNonyminus · 2021-06-20T20:05:36Z

Half Life 2 The Orange Box (BLUS30055) crashes rpcs3 when saving states, before the file is even made.
Tested in the opening of Half Life 2.
Log: RPCS3.log

Jonathan44062 · 2021-06-20T21:03:26Z

Sonic Unleashed - Doesn't work with the save state and I got an error
Log:
RPCS3.log.gz
Savestate file: https://www.mediafire.com/file/axjk1j6tu2k8vc1/BLUS30244.SAVESTAT/file
Kernel Explorer Video:
https://www.youtube.com/watch?v=0HvW2z9M4Ps

AphelionWasTaken · 2021-06-20T23:17:01Z

FFX Remaster - creating or loading a savestate causes the ground to render improperly. It appears black except for where characters are standing. No other observed issues.

RPCS3 FFX.log.gz
https://user-images.githubusercontent.com/61633628/122690063-d3c01500-d1ec-11eb-8914-1dc3589f3116.mp4

Rainbow 6 Vegas 2 - No observed issues.
RPCS3 Vegas.log.gz
https://user-images.githubusercontent.com/61633628/122690228-e5ee8300-d1ed-11eb-8ccb-a4befb679ed3.mp4

Tales of Xillia 2 - No observed issues.
RPCS3 Xillia 2.log.gz
https://user-images.githubusercontent.com/61633628/122689930-b63e7b80-d1eb-11eb-92bf-a761d9cca1d9.mp4

SSX - Creating or loading a savestate causes a graphical issue with the snow around your character. This issue does go away after a short amount of time.

Attempting to create a savestate after restarting a drop causes the emulator to crash. It fails to create a savestate in this situation.

Log (successful savestate)
RPCS3 SSX.log.gz
Kernel Explorer (successful savestate)
https://user-images.githubusercontent.com/61633628/122689671-25b36b80-d1ea-11eb-96bc-1b791daec4b1.mp4
Log (crash)
RPCS3 SSX Crash.log
Kernel Explorer (crash)
https://user-images.githubusercontent.com/61633628/122690670-93629600-d1f0-11eb-87fb-65a9ace98ba0.mp4

Haze - No observed issues.
RPCS3.log.gz
https://user-images.githubusercontent.com/61633628/122689536-e3d5f580-d1e8-11eb-9ed2-7908c2c933f5.mp4

Skate 2 - Creating a savestate crashes the emulator while the game reloads. Attempting to load this savestate also causes the emulator to crash while the game boots.
RPCS3 Skate 2.zip
https://user-images.githubusercontent.com/61633628/122691153-83988100-d1f3-11eb-804c-902575b25f3b.mp4

Crafty-The-Fox · 2021-06-21T00:59:40Z

DJ Hero 2 Demo - Creating a savestate crashes the emulator while the game reloads.

RPCS3 DJ Hero 2 Demo.zip

2021-06-20.20-51-45-1.mp4

Kilowog01 · 2021-06-21T04:01:13Z

LittleBigPlanet™ [BCES00611]-Savestate doesn't load
RPCS3.log.gz
https://drive.google.com/file/d/1Zrut6uufzUcuOLyIL6ccQkQyoijSa_Np/view?usp=sharing
https://user-images.githubusercontent.com/16064499/122705023-45b74f00-d22b-11eb-9625-a81009f50c61.mp4

elad335 · 2021-06-21T09:36:42Z

Anyone has visual studio and can get me callstacks for crashes?

Satan86 · 2021-06-21T21:08:10Z

RPCS3 crashes whenever I try to boot a game with VS attached, no idea why. Will have to figure that out first

elad335 · 2021-06-22T02:37:09Z

You need to disable "break when this exception type is thrown" for RSX access violations to work.

Satan86 · 2021-06-22T19:52:20Z

Thanks for the suggestion, VS debugger is working. Got some callstacks:

Loading savestates on Motorstorm

Loading savestates on Ridge Racer 7

Loading savestates on Gran Turismo 5

Loading savestates on The Last Of Us

Loading savestates on Skate 3

Loading savestates on Motorstorm Apocalypse

elad335 · 2021-06-24T11:34:19Z

Fixed UNIX builds, added debugging info for crashes.

rpcs3/Emu/CPU/CPUThread.h

Megamouse · 2022-06-29T20:14:58Z

rpcs3/Emu/Cell/PPUThread.cpp

+			thread_ctrl::wait_on<atomic_wait::op_ne>(g_progr_ptotal, 0);
+			g_fxo->get<progress_dialog_workaround>().skip_the_progress_dialog = true;
+
+			// Sadly we can't postpone initializing guest time because we need ti run PPU threads


Suggested change

// Sadly we can't postpone initializing guest time because we need ti run PPU threads

// Sadly we can't postpone initializing guest time because we need to run PPU threads

Megamouse · 2022-06-29T20:28:37Z

rpcs3/util/fixed_typemap.hpp

+			// Save data in forward order
+			for (u32 i = _max; i; i--)
+			{
+				if (auto save = (*std::prev(m_info, i))->save) save(*std::prev(m_order, i), ar);


Suggested change

if (auto save = (*std::prev(m_info, i))->save) save(*std::prev(m_order, i), ar);

if (auto save = (*std::prev(m_info, i))->save)

{

save(*std::prev(m_order, i), ar);

}

kd-11

I only got halfway, there are too many instances of the same issues anyway, but the summary is pretty simple - there are way too many changes that are not directly related to savestates included here. These really should have been submitted incrementally. The reason for this is pretty simple. Users bisect on changeset, not commit. With this uber-PR, any mistakes will break the whole thing and cause emergency reverts of large sections to unbreak. It's just too difficult to follow which part potentially affects what, potential performance impact, etc. I have no doubt there will be problems - there always are will large PRs, the only difference is that this time only the original code author will be able to fix them.

kd-11 · 2022-07-02T18:33:05Z

Utilities/File.h

@@ -694,6 +701,7 @@ namespace fs
 		bool trunc(u64 length) override
 		{
 			obj.resize(length);
+			update_time(true);


This is unrelated to savestates. Why have it submitted with such a massive PR?

No, this is for POSIX allowence of deletion of files with opened file descriptors in savestates. In this case I convert the file descriptor to memory and added missing functionality so it can be used by cellFs.

kd-11 · 2022-07-02T18:33:42Z

Utilities/File.h

+	private:
+		stat_t m_stat{};
+
+		void update_time(bool write = false)


Ditto, this should have been submitted separately, though the same can be said for large parts of this changeset.

kd-11 · 2022-07-02T18:34:23Z

rpcs3/Crypto/unedat.h

@@ -26,11 +26,17 @@ struct loaded_npdrm_keys
 	}

 	// TODO: Check if correct for ELF files usage
-	u128 last_key() const
+	u128 last_key(usz backwards = 0) const


Also unrelated/splittable.

kd-11 · 2022-07-02T18:35:29Z

rpcs3/Emu/Cell/Modules/cellAudio.cpp

@@ -615,6 +661,11 @@ void cell_audio_thread::operator()()

 	thread_ctrl::scoped_priority high_prio(+1);

+	while (Emu.IsPaused())


An odd inclusion. Why is this here? Why now?

kd-11 · 2022-07-02T18:37:06Z

rpcs3/Crypto/unedat.h

 	}
+
+	SAVESTATE_INIT_POS(2);


I see a lot of these sprinkled all over the code, they really should use an enum to ease maintenance.

kd-11 · 2022-07-02T18:55:23Z

rpcs3/Emu/Cell/PPUModule.cpp

@@ -1975,7 +2131,17 @@ std::pair<std::shared_ptr<lv2_overlay>, CellError> ppu_load_overlay(const ppu_ex
 			if (prog.bin.size() > size || prog.bin.size() != prog.p_filesz)
 				fmt::throw_exception("Invalid binary size (0x%llx, memsz=0x%x)", prog.bin.size(), size);

-			if (!vm::get(vm::any, 0x30000000)->falloc(addr, size))
+			const bool already_loaded = ar /*&& !!(_seg.flags & 0x2)*/;


Seconded. The flags check is included in other similar checks elsewhere, making this stick out.

kd-11 · 2022-07-02T18:56:28Z

rpcs3/Emu/Cell/PPUThread.cpp

@@ -1380,6 +1391,24 @@ void ppu_thread::cpu_task()
 			asm("DSB ISH");
 #endif

+			// Wait until the progress dialog is closed.
+			// We don't want to open a cell dialog while a native progress dialog is still open.
+			thread_ctrl::wait_on<atomic_wait::op_ne>(g_progr_ptotal, 0);


Yet another standalone fix

kd-11 · 2022-07-02T18:58:49Z

rpcs3/Emu/Cell/PPUThread.cpp

 {
 	if (g_cfg.core.ppu_decoder != ppu_decoder_type::llvm)
 	{
 		return;
 	}

+	if (auto dis = g_fxo->try_get<disable_precomp_t>(); dis && dis->disable)


Is this change related to savestates?

kd-11 · 2022-07-02T19:00:40Z

rpcs3/Emu/Cell/PPUThread.cpp

@@ -2560,53 +2803,48 @@ extern void ppu_precompile(std::vector<std::string>& dir_queue, std::vector<lv2_

 			std::string upper = fmt::to_upper(entry.name);

-			// Check .sprx filename
-			if (upper.ends_with(".SPRX") && entry.name != "libfs_utility_init.sprx"sv)
+			// Skip already loaded modules or HLEd ones


This is another improvement unrelated to the saving of states. You should have opened incremental PRs with the supporting fixes for easier risk management.

No, it's related to savestates. It's required to skip precompilation of already loaded modules with the addition of OVL modules checking which comes with savestating MGS4.

It is standalone though. That's what I mean. I understand that it is needed for savestates to work, but it doesn't contain the core saving of states (serialization/deserialization) and would have been good in a part 1 PR. Again, I don't expect anything to change, but I have to give advice anyway for the sake of future PRs.

kd-11 · 2022-07-02T19:01:43Z

rpcs3/Emu/Cell/PPUThread.cpp

@@ -2822,20 +3060,39 @@ extern void ppu_initialize()
 		compile_main = ppu_initialize(_main, true);
 	}

-	std::vector<lv2_prx*> prx_list;
+	std::vector<ppu_module*> module_list;


Same here. I'm not going to check for any more standalone improvements.

No, related.

Standalone, not unrelated. I'm trying to think of how to merge the whole PR without too much risk.
By standalone I mean it can be submitted separately before the "main" work, e.g in a savestates part 1 PR or something.
Not that you'll do it anyway, but still I feel it would have really helped regtesting.

elad335 · 2022-07-02T19:34:33Z

There are no unrelated changes in this pr.

Nekotekina · 2022-07-03T10:46:48Z

rpcs3/Emu/Cell/PPUThread.cpp

@@ -2230,7 +2461,7 @@ static bool ppu_store_reservation(ppu_thread& ppu, u32 addr, u64 reg_value)
 				{
 					if (count > 20000 && g_cfg.core.perf_report) [[unlikely]]
 					{
-						perf_log.warning(u8"STCX: took too long: %.3fµs (%u c)", count / (utils::get_tsc_freq() / 1000'000.), count);
+						perf_log.warning(u8"STCX: took too long: %.3fÂµs (%u c)", count / (utils::get_tsc_freq() / 1000'000.), count);


Another corrupted unicode string.

bnthomason · 2022-07-03T16:28:36Z

Is this a bug? In White Knight Chronicles II (Haven't tested any other game yet), doing consecutive save states (3 total, Boot Game > Save > Load Save > Save > Load Save > Save > Load Save > Crash) will cause the savestate in question to be corrupted

Nekotekina · 2022-07-04T10:33:26Z

I think it can be merged once minor unicode string corruptions are fixed.

vsub · 2022-07-17T16:44:54Z

Sorry for bumping this but how exactly this work?
How do I create a save state and how to load it

AniLeo · 2022-07-17T16:46:37Z

https://wiki.rpcs3.net/index.php?title=Help:Save_State

vsub · 2022-07-17T18:32:14Z

https://wiki.rpcs3.net/index.php?title=Help:Save_State

Thanks

elad335 mentioned this pull request Jun 20, 2021

Feature Request : Save state #4218

Closed

elad335 force-pushed the savestates branch 2 times, most recently from 791859a to 321e4a8 Compare June 20, 2021 08:48

elad335 force-pushed the savestates branch from 321e4a8 to c84a49e Compare June 20, 2021 08:51

Megamouse added the Savestates Anything that involves savestates label Jun 21, 2021

elad335 force-pushed the savestates branch 5 times, most recently from 5cd1a5d to c9804f0 Compare June 24, 2021 11:33

elad335 force-pushed the savestates branch 3 times, most recently from 95014d6 to 4d6e935 Compare June 24, 2021 16:21

elad335 force-pushed the savestates branch 5 times, most recently from 3cb80e0 to f1a3716 Compare June 28, 2022 15:14

Nekotekina reviewed Jun 28, 2022

View reviewed changes

rpcs3/Emu/CPU/CPUThread.h Outdated Show resolved Hide resolved

kd-11 self-requested a review June 28, 2022 16:04

elad335 force-pushed the savestates branch 3 times, most recently from 82b56b7 to 055820a Compare June 28, 2022 17:12

Savestates Support For PS3 Emulation

03147ba

elad335 force-pushed the savestates branch from 055820a to 03147ba Compare June 28, 2022 17:23

Megamouse reviewed Jun 29, 2022

View reviewed changes

kd-11 reviewed Jul 2, 2022

View reviewed changes

Nekotekina reviewed Jul 3, 2022

View reviewed changes

elad335 added 2 commits July 4, 2022 13:53

Minor fixup

a138445

Merge branch 'master' into savestates

3c4edf2

elad335 requested a review from Nekotekina July 4, 2022 12:10

Nekotekina merged commit fcd297f into RPCS3:master Jul 4, 2022

This was referenced Jul 4, 2022

Various games segfault rpcs3 upon boot from 0.0.23-13834 onwards #12304

Closed

Significant performance regression with noticeably increased CPU utilization in games since 0.0.23-13834 (#10478) #12311

Closed

JimScript mentioned this pull request Jul 9, 2022

Regression: RSX Captures fatal crash the emulator after Savestates (#10748) #12330

Closed

solarmystic mentioned this pull request Jul 15, 2022

Soulcalibur V [BLUS30736] : Hangs after entering main Quick Battle screen from 0.0.23-13834 onwards. #12353

Closed

	// Sadly we can't postpone initializing guest time because we need ti run PPU threads
	// Sadly we can't postpone initializing guest time because we need to run PPU threads

		@@ -615,6 +661,11 @@ void cell_audio_thread::operator()()

		thread_ctrl::scoped_priority high_prio(+1);

		while (Emu.IsPaused())

Savestates #10478

Savestates #10478

Conversation

elad335 commented Jun 19, 2021 • edited Loading

Restrictions (most will be lifted as this work progresses):

How to savestate

Versioning System

Savestates modes (config.yml exclusives at the moment)

Additional TODO list: (besides lifting restrictions)

elad335 commented Jun 20, 2021 • edited Loading

elad335 commented Jun 20, 2021

elad335 commented Jun 20, 2021 • edited Loading

elad335 commented Jun 20, 2021 • edited Loading

elad335 commented Jun 20, 2021

Satan86 commented Jun 20, 2021

ChrisNonyminus commented Jun 20, 2021

ChrisNonyminus commented Jun 20, 2021

Jonathan44062 commented Jun 20, 2021

AphelionWasTaken commented Jun 20, 2021 • edited Loading

Crafty-The-Fox commented Jun 21, 2021

Kilowog01 commented Jun 21, 2021

elad335 commented Jun 21, 2021

Satan86 commented Jun 21, 2021

elad335 commented Jun 22, 2021

Satan86 commented Jun 22, 2021

elad335 commented Jun 24, 2021

Choose a reason for hiding this comment

Megamouse Jun 29, 2022 • edited Loading

Choose a reason for hiding this comment

kd-11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elad335 Jul 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elad335 Jul 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elad335 commented Jul 2, 2022

Choose a reason for hiding this comment

bnthomason commented Jul 3, 2022

Nekotekina commented Jul 4, 2022

vsub commented Jul 17, 2022

AniLeo commented Jul 17, 2022

vsub commented Jul 17, 2022

elad335 commented Jun 19, 2021 •

edited

Loading

elad335 commented Jun 20, 2021 •

edited

Loading

elad335 commented Jun 20, 2021 •

edited

Loading

elad335 commented Jun 20, 2021 •

edited

Loading

AphelionWasTaken commented Jun 20, 2021 •

edited

Loading

Megamouse Jun 29, 2022 •

edited

Loading

elad335 Jul 2, 2022 •

edited

Loading

elad335 Jul 2, 2022 •

edited

Loading