-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Fix second VBlank, add setting to control its frequency #12060
base: master
Are you sure you want to change the base?
Conversation
eee8099
to
aa98800
Compare
|
hi, quick question, does this mean, we dont use Game Patches anymore to get 60 fps? |
Honestly that's why I tested NFS Mosted wanted which lead me to the fatal error. Lol |
Harry Potter and the Order of the Phoenix [BLUS30045] Figured the "except the ones where vblank does not work to increase fps" statement may help. |
unfortunately not possible as some games, such as LittleBigPlanet can't run at a higher framerate than 30 due to not using deltatime |
I understand that this PR would obviously break other games, but is it fine if this build gets updated again? I would like to test this PR for NFS The Run to see if theres any or no differences when using vblank. |
aa98800
to
fa18e22
Compare
Did you have the binaries for the old version downloaded? I cant find the old ones and the newest build didnt build properly. |
I dont have the old version for this PR downloaded, and even if I did, then it would be very outdated to test it. Due to tons of updates/bugfixes that has been merged from this emulator. |
The game that i want to test has a really old regression anyways. |
fa18e22
to
816df22
Compare
816df22
to
c0c18e6
Compare
There are 2 vblank signals, the first is meant to update at the rate of video output.
The second is a software interrupt usually fixated at 59.94hz, most commonly used to convert logic meant for 59.94hz displays to the real display such as 59.94hz encoded videoes, gameplay logic etc. On real ps3 this had a meaningful use with displays that only output at odd rates such as 50hz for example.
I have added a setting to control it in config.yml
To users: added a setting to control its frequency in config.yml called "Second Vblank Rate". If 0 (default), it synchronizes with the first VBlank rate, otherwise the value set controls it.
It may help override games' frame cap that is dependent on the first VBlank rate, but their game logic is dependent on the second.