Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU LLVM: Optimize inline MFC transfers #12080

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

Whatcookie
Copy link
Member

Tiny optimization, use wider instructions when possible. Likely no noticeable improvement outside of synthetics.

- Use wider instructions when possible
@Megamouse Megamouse added CPU Optimization Optimizes existing code labels May 24, 2022
@YuriNator557
Copy link

Seems slightly slower than master in the SPU test? Could just be test variance but all 3 tests were slower than master.
spu test pr 12080.txt

@Xcedf
Copy link

Xcedf commented May 25, 2022

12900k Slightly better
master:
SPU MFC 64 Bits War completed in 4649 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 7069 ms (PS3: 4443 ms)
PR:
SPU MFC 64 Bits War completed in 4487 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 6573 ms (PS3: 4443 ms)

@Darkhost1999
Copy link
Contributor

What CPUs?

Ryzen 5 3600
Master
SPU MFC 64 Bits War completed in 8872 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 12119 ms (PS3: 4443 ms)
PR
SPU MFC 64 Bits War completed in 9092 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 12171 ms (PS3: 4443 ms)

@Whatcookie
Copy link
Member Author

I don't think it should have any impact on the 64 bit MFC tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPU Optimization Optimizes existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants