Move test elfs to test dir

[Megamouse]

TEST12345 is already taken by dev builds

[kd-11]

You can pick another titleID like RPCS34567. If they are in bin how do you trivially them on linux appimages for example? Users should not need to search for these.

[elad335]

I vote putting it outside of games' file system visibility as well, shouldn't be accessible by them and they can delete it in theory.

[MSuih]

I don't think they are included in appimages anyways, are they? People do seem to need to download these manually on Linux.

Or if they are then maybe they're not extracting properly.

[RainbowCookie32]

I don't think they are included in appimages anyways, are they? People do seem to need to download these manually on Linux.

Or if they are then maybe they're not extracting properly.

If they are, I was never able to find them. Maybe it's hidden somewhere inside the AppImage itself, but dev_hdd0 never had them out of the box, I had to get them from GitHub or a Windows zip.

[kd-11]

I don't think they are included in appimages anyways, are they? People do seem to need to download these manually on Linux.

Or if they are then maybe they're not extracting properly.

Then this is a bug.
While most developers don't care much about these, they are very useful when diagnosing user-specific problems. The first thing we ask users reporting issues is to run triangle test and cube test just to make sure they didn't mess up their graphics drivers too badly in the first place. This is a much easier way to get a layman to test a sample that allows us to eliminate game-specific weirdness.

In the end, you can put them wherever, it just needs to be easy to find. Or you can add some debug menu to the GUI to access them or something.

[Megamouse]

I don't feel like fixing a Leenux bug xD

[RipleyTom]

GuiConfigs are atm stored inside the Appimage and require special code to handle( see https://github.com/RPCS3/rpcs3/blob/master/rpcs3/rpcs3qt/gui_application.cpp#L557 ). There is no easy way to do the same for the test elfs since the appimage basically extracts in a random tmp directory. If we include the test elfs with the appimage they'd end up in said random directory.

We could in theory copy them from the tmp directory to ~/.config/rpcs3/test/ but that'd need to be done on each boot of rpcs3, or at least do a hash of the files vs the hash of the appimage files and then overwrite if they're not the same. Thought that'd overwrite new tests with old tests if using an old appimage which might not be desired...

    install(DIRECTORY ../bin/test
        DESTINATION ${CMAKE_INSTALL_DATADIR}/rpcs3)

at https://github.com/RPCS3/rpcs3/blob/master/rpcs3/CMakeLists.txt#L194 to add them to the AppImage.

[Megamouse]

Whatever floats your boat

[Nekotekina]

Maybe make a special boot menu for tests? That could work for appimages as well.

[Darkhost1999]

You know how there is log and tty tabs?
What if we did Games List and tests tabs but for the games list.
The idea is to allow importing custom elfs there as well as including the test elfs.
The 2nd idea is we could allow custom configs for the elfs allowing the same configuring for them as we do our eboot.bin files. This would solve custom configs for VSH as well if implemented. But doesn't exactly discuss where are we going to store the TEST12345 files. Have we settled on an idea?

[elad335]

Maybe store them online.

[Megamouse]

It's pointless to show tests in the game list.
It's useless for 99.9% of all users.
In my opinion it's enough to have them in some dir and boot them with the menu.
Of course we could add a menu option that opens the proper dir already.

[elad335]

Tests should run on all RPCS3 versions, making them online not only solves this problem but also allows an official way to use the latest hw tests to compare the performance/accuracy of all RPCS3 builds in addition to saving RPCS3 package space.

[Megamouse]

That's completely missing the point of this PR

[Megamouse]

I don't care where they are i just want them out of my elveon dir xD

[RipleyTom]

A work of art! (I'll fix the linux thing in a separate PR)

[Vestrel]

Should close #11326