-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTERS NEEDED] cellAudio: Implement audio format options, scrap downmix options #12112
Conversation
599f8ac
to
b8e7dcc
Compare
4715fca
to
4044c3d
Compare
I completely reworked this PR. |
Added automatic option |
6d4fa7a
to
6f9bab6
Compare
Can't test just yet, but does automatic always choose the highest supported by the game? You probably don't wanna go above what the host audio system is capable of. |
The issue is that some games may not like it if you don't provide a format that it can handle. I could add a second automatic stereo option that omits all surround formats. idk |
Added 2ch always by default. |
you know what? I'll just add the stupid checkbox list xD Would be nice to know if the current approach is working better now though |
I would honestly prefer the dropdown menu. Especially if you choose to combine the 5.1 options. Then you could just name the options "Stereo", "Surround 5.1" and "Surround 7.1". So much better in my opinion. |
I can still add three options that basically do what you suggested. I don't have to remove the manual mode. |
7ef6bee
to
dbe8204
Compare
Added. Please let me know if everything works as expected |
@Megamouse |
Looking good I also tested PS3 behavior a bit and I can confirm that cellAudioOutConfigure doesn't return any error codes if invalid settings are in the config struct. It simply continues to use the last valid config and returns 0. |
Thanks. I'll cook something up when I have time |
what does cellAudioOutGetDeviceInfo return and in what order are the modes in info.availableModes returned? |
With everything enabled it returns this:
Coding type 8 is Dolby TrueHD, 10 is DTS-HD and 11 is DTS-HD MA. |
which modes exactly are 8, 10 and 11 ? |
I won't sort the availableModes, I don't think it really matters. |
"Also, documentation says secondary output only supports LPCM 2.0 so we probably don't wanna add anything more as available. I'm gonna test some more later with USB audio devices, see how it behaves." Ah, I mistook the primary out headset for the secondary out |
This enables the downmix mode "Use application settings".The game can now decide which channel count is used with cellAudioOutConfigure.
Therefore I recommend using Automatic in the global config