-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Partial handling of surface pitch change #12469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes when you use Ryno V Testeo.en.Master.mp4PR Testeo.en.PR.Fix.mp4 |
Performance is a little weird with some of the games in this series. It will be fixed in future. |
8 tasks
Megamouse
reviewed
Aug 6, 2022
kd-11
changed the title
[TESTERS NEEDED] rsx: Partial handling of surface pitch change
rsx: Partial handling of surface pitch change
Aug 7, 2022
@kd-11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pitch of a surface is changed, the only way to preserve data is to do a cache flush and rebuild from raw memory. While this is a huge task in and of itself, we do not need to implement all of that. For now, just set erase background flag but keep the old memory access tag. This forces a memory reload.
Of course this setup falls on its face if certain combinations of options are enabled, so I'd like to get some testing going.
I will still implement the full version of this, but it will take a long while to get ready (some re-architecting is required).
The only game I found affected by this issue is R&C ACiT, but I'm sure there are others.
Fixes #11205