RawSPU: Do not assume GPU memory fault on SPU MMIO #12587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
Aug 31, 2022
kd-11
approved these changes
Aug 31, 2022
|
A bit late on my end (I wanted to test this before it got merged but couldn't make it in time), but this PR (which is now merged to master) caused a minor performance regression with Demon's Souls. Current master with this commit merged (0.0.23-14102) - 83 Average FPS Previous build (0.0,23-14099) - 85 Average FPS |
|
Hi, DeS doesn't use RawSPUs. |
I did retest again and it was indeed a random performance fluctuation, well within margin of error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massively improves the performance of RawSPU MMIO and PS3 page faults notifications.