Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix USIO fault when it received unsupported FW commands #12593

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix USIO fault when it received unsupported FW commands #12593

merged 1 commit into from
Sep 7, 2022

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Sep 1, 2022

Fixed the following error which occurred when the game attempted to send firmware-related commands (such as FW update and reset state):
F {PPU[0x1000019] Thread (usj_usio_worker_thread) [0x019c85e8]} usio_log: Unexpected write channel: 0x01!

It needn't handle FW updates as the emulation doesn't use any firmware.

@RipleyTom
Copy link
Contributor

RipleyTom commented Sep 4, 2022

I'd rather you comment inside the code what this channel does even if you don't handle it and just put a break instead of changing the fatal to a todo.
Also please if you remove info from the code, leave it as a comment( like the {0xA0, 0xF0, 0x28, 0x00, 0x00, 0x80} boot command which is the one sent by Taiko no Tatsujin, it may be useful to someone else improving it at one point ).

@brian218
Copy link
Contributor Author

brian218 commented Sep 5, 2022

I'd rather you comment inside the code what this channel does even if you don't handle it and just put a break instead of changing the fatal to a todo. Also please if you remove info from the code, leave it as a comment( like the {0xA0, 0xF0, 0x28, 0x00, 0x00, 0x80} boot command which is the one sent by Taiko no Tatsujin, it may be useful to someone else improving it at one point ).

@RipleyTom Thanks for the notice. I've updated the code.

@Nekotekina Nekotekina merged commit 9087116 into RPCS3:master Sep 7, 2022
@brian218 brian218 deleted the patch-1 branch September 7, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants