Utility fixups #12977
Merged
Utility fixups #12977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Nov 24, 2022
|
I think vm::ref is suitable for this, with minor additions. |
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
1c109be
to
e1ca9ed
Compare
elad335
reviewed
Nov 25, 2022
| constexpr aref& operator=(const T& value) const | ||
| { | ||
| write_to_ptr<T>(value, m_ptr); | ||
| } |
Nekotekina
force-pushed
the
master
branch
6 times, most recently
from
de8dc3e
to
5fc15a4
Compare
|
I guess I'll repurpose vm::ref in another PR |
elad335
reviewed
Nov 25, 2022
rpcs3/util/types.hpp
Outdated
| } | ||
|
|
||
| template <typename T, typename U> | ||
| constexpr void write_to_ptr(const T& value, U&& array, usz pos = 0) |
There was a problem hiding this comment.
Swapping argument places is more consistent with vm::writeX methods.
It can also have an overload which takes a single argument of array referece paired with index. So you can write wtite_to_ptr({array, 1}, data)
|
Tested a handful of games, they work just fine |
Doing std::bit_cast on a "span". Should be usable in constexpr.
Type `aref`: reference wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some TODOs and some new functionality: tool to avoid UB and able to replace misused reinterpret_cast and utils::bless. Done by avoiding referencing trivial objects in memory or arrays and just use memcpy on reads and writes.