Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_game: Made the LV2 Watchdog restarts the game forcefully #13074

Merged
merged 2 commits into from
Dec 15, 2022
Merged

sys_game: Made the LV2 Watchdog restarts the game forcefully #13074

merged 2 commits into from
Dec 15, 2022

Conversation

brian218
Copy link
Contributor

Whenever the LV2 Watchdog is triggered, the game should have already been ready to be killed forcefully (and then restarted).

@Megamouse
Copy link
Contributor

Is there any issue that leads to this change?

@brian218
Copy link
Contributor Author

Is there any issue that leads to this change?

It took too long (around10 seconds), compared to the timeout value specified by the game (5 seconds), to shutdown the game before actually restarting the game.

Copy link
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably incorrect to use graceful shutdown in the first place because it is a watchdog afterall.

@brian218
Copy link
Contributor Author

The 2nd commit solves the bug that some games using LV2 Watchdog got restarted automatically after a player closed the game by clicking the cross button on the game window.
It was due to the time gap (7s by default) between when CELL_SYSUTIL_REQUEST_EXITGAME is issued by Emu.GracefulShutdown() and when Emu.Kill() is called by Emu.GracefulShutdown(); and the timeout value used for LV2 Watchdog is usually set to 5s, so there was a chance that the LV2 Watchdog got triggered before it was really aborted by Emu.Kill().

@Megamouse
Copy link
Contributor

I kinda doubt that it takes 7 seconds to close the game.
Maybe you could try to find out why it takes that long in the first place.
(Not saying that killing the watchdog is wrong here)

rpcs3/Emu/Cell/Modules/cellSysutil.cpp Outdated Show resolved Hide resolved
@Nekotekina Nekotekina merged commit 812224f into RPCS3:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants