Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSH/UI: Add VSH to game grid #13176

Merged
merged 3 commits into from
Jan 7, 2023
Merged

VSH/UI: Add VSH to game grid #13176

merged 3 commits into from
Jan 7, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 7, 2023 •
edited
Loading

  • Custom VSH config.
  • VSH shortcut creation.

image

@Megamouse Megamouse added GUI Loader Involving the load of PS3 file formats VSH labels Jan 7, 2023
@ghost
Copy link

ghost commented Jan 7, 2023

VSH image should be changed because the icon is literally PlayStation Home.

@Darkhost1999
Copy link
Contributor

If you got a better icon just right click-> custom icon. And replace it.

Megamouse
Megamouse reviewed Jan 7, 2023
View reviewed changes
rpcs3/Emu/System.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/System.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/emu_settings.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/game_list_frame.cpp Outdated Show resolved Hide resolved
@Megamouse
Copy link
Contributor

I think the name could be more user friendly. vsh.self isn't very descriptive for the average user.
As a new user I'd wonder what that's supposed to be

@elad335
VSH/UI: Add VSH to game grid
592b7e0 
* Custom VSH config.
* VSH shortcut creation.
@elad335
Copy link
Contributor Author

elad335 commented Jan 7, 2023

Added.

@MSuih
Copy link
Member

MSuih commented Jan 7, 2023 •
edited
Loading

I still think we should use different icon than the one for PS Home. Maybe a screenshot of the background would be enough?

Gave this a quick spin and it does work, everything seems fine to me. Most importantly the icon can be hidden from list

@elad335
Copy link
Contributor Author

elad335 commented Jan 7, 2023 •
edited
Loading

it can be revised later. It needs to consider rpcs3 package size, offline availability etc, so the image from dev_flash has been the easy choice. You can pr it.

@Megamouse Megamouse merged commit 8eefbca into RPCS3:master Jan 7, 2023
@elad335 elad335 deleted the game-vsh branch January 9, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse approved these changes

Assignees
No one assigned
Labels
GUI Loader Involving the load of PS3 file formats VSH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elad335 @Darkhost1999 @Megamouse @MSuih