rsx_debugger: replace malloc with buffer cache #13372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Megamouse
commented
Feb 7, 2023
Megamouse
commented
- Use buffer cache instead of allocating a raw buffer
- This also happens to fix a memory leak in the stencil buffer widget
This also fixes a memory leak.
kd-11
reviewed
Feb 7, 2023
| @@ -577,7 +573,8 @@ void rsx_debugger::OnClickDrawCalls() | |||
| if (width && height && !draw_call.depth_stencil[1].empty()) | |||
| { | |||
| const std::span<const std::byte> orig_buffer = draw_call.depth_stencil[1]; | |||
| u8* buffer = static_cast<u8*>(std::malloc(4ULL * width * height)); | |||
There was a problem hiding this comment.
How'd this ever get merged? 👀
There was a problem hiding this comment.
probably as part of the first Qt or wx pr xD
|
I hope this works, because i didn't test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.