PPU LLVM: Fix crash in Unity games (regression) #15477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
ppu-serach
branch
2 times, most recently
from
49ff68a
to
33e6a48
Compare
|
This looks promising, hopefully it helps with this FF XIII regression, too. #14909 EDIT: A bit later, but it still crashes with PPU LVM while compiling PPU modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing on discord, https://discord.com/channels/272035812277878785/277227681836302338/1230390083736047667
This happend because JIT instance was not initialized due to a failure to find functions.
I fixed that and also added an experimental fallback to find PPU functions using callers like in SPU precompilation.