Revert "Split normal sockets and p2p sockets handling" #15511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08c3a38.
Megamouse
reviewed
Apr 27, 2024
| @@ -437,9 +437,18 @@ namespace rpcn | |||
| void remove_message_cb(message_cb_func cb_func, void* cb_param); | |||
| void mark_message_used(u64 id); | |||
|
|
|||
| bool is_connected() const; | |||
There was a problem hiding this comment.
I think you can keep all the changes in this file
There was a problem hiding this comment.
When doing a revert for the purpose of reverting a regression its better to make it a clean revert and not touch anything in the original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 08c3a38.