Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM to 19.1.7 #16620

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update LLVM to 19.1.7 #16620

wants to merge 2 commits into from
+25 −12

Conversation

Megamouse
Copy link
Contributor

  • Updates llvm to 19.1.7

TODO:

  • docker update
  • prebuilt libs

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label Jan 25, 2025
@Megamouse Megamouse marked this pull request as draft January 25, 2025 17:26
Darkhost1999
Darkhost1999 reviewed Jan 25, 2025
View reviewed changes
rpcs3/emucore.vcxproj
<AdditionalDependencies Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">ntdll.lib</AdditionalDependencies>
</Lib>
<Lib>
<AdditionalDependencies Condition="'$(Configuration)|$(Platform)'=='Release|x64'">ntdll.lib</AdditionalDependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to
llvm/llvm-project@cc7a18c
When I mentioned LLVMSupport.lib; ntdll.lib and unresolved linker error
#16607 (comment)
I am just trying to learn more about why this change is needed and how to identify it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, but apparently it's needed now for some reason

@Megamouse Megamouse force-pushed the llvm19 branch 2 times, most recently from 7471f9c to f66221b Compare January 28, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkhost1999 Darkhost1999 Darkhost1999 left review comments

Assignees
No one assigned
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Megamouse @Darkhost1999