-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: impossible to reference macros in subdirectories of addon with macro links #3259
Comments
The problem appears to be in the regular expression used to parse the macro links. In a link like
the above regular expression will match
|
Assign this to me, I will give it a try at fixing as suggested in the discord chat |
Changed all the regular expression related to MacroLinkFunction class to directly match the longest possible path in the macro path.
Uploading the following two files to expose the problem. The add on exposes a macro in the There is a macro in the Campaign window of the campaign which will call the add-on. This doesn't work with MapTool 1.12.2, but works with the fix applied. |
Describe the Bug
macro links with / don't work , and neither does escaping them.
To Reproduce
Expected Behaviour
macros in addons should be able to be linked even if in subdirectories
Screenshots
No response
MapTool Info
1.11.3
Desktop
arch linux
Additional Context
No response
The text was updated successfully, but these errors were encountered: