[Feature]: Add proper html support for token notes. #3791
Comments
|
I already have this in my personal use branch. I combined the JFX HtmlEditor control with rsyntaxtextarea. |
Any potential issues with that? Likely to break on future Java releases? |
|
Not more likely than our other JavaFX Controls breaking. Its just a JPanel with two tabs. Nothing complicated: Only issue is that JavaFX controls don't use the flatlaf themes. |
|
I will wait with a PR until #3785 is merged because this change depends on that. |
|
Nice. |
|
Tested. Better HMTL support in notes. Seems to add in extra whitespace but the HTML can be edited directly if needed. |
Phergus
added
the
tested
|
I like this editor, it looks handy. I'm going to push back on one aspect of these changes though: we should not force notes to be HTML. There are existing campaigns and well-established frameworks that use notes for purposes other than the built-in notes overlay, and which cannot function properly if the notes are modified. E.g., I personally make use of Rod's 5e framework which makes liberal use of markdown, including storing it in notes / GM notes. With the notes being turned into HTML documents, the framework is no longer able to properly render the markdown into HTML fragments that can be inserted into frames, and it breaks the custom roll links built into the framework. And one minor bug I found while testing that out: most stamps will now count as markers since even empty notes and GM notes still store HTML content. So clicking on an object with no notes, GM notes or portrait results in a teeny tiny empty notes overlay: Brand new tokens are exempt until edited. |
Agreed. Do we have control over the tabs at the bottom? Could a third one for Markdown be added? IIRC, rsyntaxarea is capable of supporting just about any syntax highlighting if we can find/create our own regexes to handle where each type of highlighting begins and ends. For upward compatibility... When loading a campaign, if the first characters (skipping leading whitespace, of course) are |
|
Maybe we should just put the format of the notes into the campaign properties? Not sure if it different token in the same campaign should have different formats of notes. |
IMO we should just add relevant fields to Token or CampaignProperties and check if we are opening an old campaign and ask the use what type of notes he wants. |
|
Auto detection would always fallback to plain text (unless the user selects otherwise in Preferences). So only HTML and Markdown formats would be processed (HTML AS IS, while Markdown would be converted to HTML on the fly). We already auto detect a lot of stuff when reading the campaign and always have; it’s one reason why MT can read campaigns from 15 years ago with minimal impact. Each token has its own settings, as some on the Object layer may just be informational and used by the GM or players as reference points, while others might have more formatted info in them or even data (as you point out). |
From my own experience, it is sometimes useful to have different tokens use different formats. E.g., most tokens operate under a framework, but there are other that you do want to use with the built-in notes display. Or by using more than one framework, each with different assumptions. I think we should just aim to have MT be less opinionated about the contents of the notes. This can be done with small tweaks to the current state of things. We also don't need special support for markdown or any other kind data, as long as we leave things alone unless asked to do otherwise (we could have support for others, but it's in no way needed). Here is an example of how we can preserve existing data while keeping things mostly the same:
And there's plenty of room to do other things on top of that that could improve the user experience. E.g.:
I'm not actually suggesting or requesting any of these, I only put them there to prove the point. Shifting gears, I was doing more testing and found another quirk, which I guess is what Phergus is referring to as well:
There can be quite a bit of extra vertical space added depending on the size of the notes. E.g.,: This seems to be the result of embedded a complete HTML document (
From this angle, it makes sense to extract the ( |
|
I'll add a text type for notes and gmnotes for now with text/plain as default. Supported mime type will be text/plain, text/html and text/markdown. I'll reorder the tabs making TXT the first one the HTML tab also works as a (not editable) preview for markdown. I'll also only store the content of the body tag from the html editor. |
Feature Request
Currently one can use html tags in token notes, but there is no proper html editor for them. Also the hover display inserts
for every linebreak in the notes. One can only work around it by having all html code in one line.
The Solution you'd like
I would also like to be able to just copy & paste content from websites into those fields and keep formating.
Best would be a WYSIWYG editor for html with the ability to edit the source code if necessary.
Alternatives that you've considered.
Only using one line of html text. But I still can't paste HTML this way.
Additional Context
No response
The text was updated successfully, but these errors were encountered: