Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature htmltokennotes #3794

Merged
merged 4 commits into from
Dec 27, 2022
Merged

Conversation

thelsing
Copy link
Collaborator

@thelsing thelsing commented Dec 27, 2022

Identify the Bug or Feature request

Closes #3791

Description of the Change

  • add a html editor control with source code editing and use it in TokenEditDialog
  • only insert
    for \n in hover note if note doesn't start with <html
  • use default hexcode formater instead of 3rd party lib

Possible Drawbacks

The third change might create different GUIDs from before. But this would be a hard to miss bug.

Documentation Notes

In the source editor you can search with CTRL-F and replace with CTRL-H

Release Notes

  • add HTML editor for token notes

This change is Reviewable

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @thelsing)

@Phergus Phergus merged commit 7f944a6 into RPTools:develop Dec 27, 2022
@thelsing thelsing deleted the feature-htmltokennotes branch January 2, 2023 21:39
@cwisniew cwisniew added the feature Adding functionality that adds value label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Feature]: Add proper html support for token notes.
3 participants