Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Visible area not being calculated correctly. #4043

Closed
kwvanderlinde opened this issue May 8, 2023 · 1 comment
Closed

[Bug]: Visible area not being calculated correctly. #4043

kwvanderlinde opened this issue May 8, 2023 · 1 comment
Assignees
Labels

Comments

@kwvanderlinde
Copy link
Collaborator

kwvanderlinde commented May 8, 2023

Describe the Bug

In MapTool 1.12.2 and earlier, lights and other things would only be drawn if a token in the current view could see it. Since 1.13.0, the "visible area" has accidentally been replaced with the "illuminated area", so things are being rendered for players as long as they are illuminated, exposing secret information to them.

To Reproduce

  1. Make a room with a light source in it.
  2. Put a PC in the room and expose their visible area.
  3. Move the PC out of the room so they can no longer see into it.
  4. Check the player view with the PC selected. Notice that the PC can still see the light and light source token inside the room.

This campaign file also demonstrates the problem.

Expected Behaviour

Tokens, labels, lights, etc., should not be visible to players when their tokens are not able to see them.

Screenshots

Here is the attached campaign map. The left is a room with a PC, the right is a room with a light source that the PC is not able to see, but that has had FoW previously revealed:
image

The expectation is that nothing is rendered in that room, except the map with soft FoW:
image

MapTool Info

1.13.0

Desktop

Linux Mint 21

Additional Context

No response

@kwvanderlinde kwvanderlinde self-assigned this May 8, 2023
@kwvanderlinde kwvanderlinde changed the title [Bug]: Total visible area not being calculated correctly. [Bug]: Visible area not being calculated correctly. May 8, 2023
@kwvanderlinde kwvanderlinde moved this from Todo to In Progress in MapTool 1.13.0 May 25, 2023
@kwvanderlinde kwvanderlinde moved this from In Progress to Needs Testing in MapTool 1.13.0 May 25, 2023
@Pmofmalasia
Copy link

Appears to be fixed for me on 1.13.2.

@github-project-automation github-project-automation bot moved this from Needs Testing to Merged in MapTool 1.13.0 Jul 19, 2023
@kwvanderlinde kwvanderlinde moved this from Merged to Done in MapTool 1.13.0 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants