Fix for visible area being confused with illuminated area #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than returning the entire illuminated area from `ZoneView.getVisibleArea(PlayerView)`, we now go back to returning only the illuminated area that is also covered by the vision of at least one of the view's tokens.
The `calculateVisibleArea` method has been folded into `getVisibleArea(PlayerView)`. This lets us directly use `computeIfAbsent` and return its result, giving a more robust implementation and requiring fewer redundant checks. The `VisibleAreaMeta` class has been removed in favour of directly using `Area`. No functionality depended on `VisibleAreaMeta`, and removing it simplies the use of the `visibleAreaMap` cache.
…th-illuminated-area
cwisniew
approved these changes
May 9, 2023
kwvanderlinde
deleted the
bugfix/4043-visible-area-confused-with-illuminated-area
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4043
Description of the Change
Change
ZoneView.getVisibleArea(PlayerView)to return token vision restricted to illuminated areas rather than returning the entire illuminated area for the view.I also put in some simplifications for things that bother me, i.e., the fact that
calculateVisibleArea()is a separate method, and thatVisibleAreaMetadoes nothing but transparently wrap anArea.Possible Drawbacks
Should be none.
Documentation Notes
None
Release Notes
This change is