fix webrtc #3108
Merged
fix webrtc #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwisniew should we merge this into a 1.10.4 build? |
Normally I would suggest we don't given how we have had a couple point releases already and its only one change that isn't breaking things from previous versions. But in this case it's probably worth it as it could solve connection issues and require a lot less support in the networking channel on discord :) |
|
That's what I was thinking. Easier connections; less support issues. |
cwisniew
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thelsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
part of #2945
Description of the Change
Refactors WebRtcClientConnection and WebRtcServerConnection. Call addIceCanditate on the client-side if an ice candidate signaling message is handled instead of onIceCandidate. Add more INFO output of the connection process.
Possible Drawbacks
None.
Release Notes
This change is