Rename TopologyMode to TopologyTypeSet #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Campaigns that predate terrain VBL could not be loaded without error due to the refactoring in RPTools#3148. This was because the old `Zone.topologyMode` field has the same name and type name as before the refactoring, but was structurally distinct and so could not be correctly deserialized. To avoid this, and to avoid potential other confusions with the previous enum `TopologyMode`, the new class has been renamed to `TopologyTypeSet` and methods and variable names have been updated accordingly.
cwisniew
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
kwvanderlinde
deleted the
issue-2755-hill-and-pit-vbl-backwards-compat-campaign-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses backwards compat issue for #2755
Description of the Change
Campaigns that predate terrain VBL could not be loaded without error due to the refactoring in #3148. This was because the old
Zone.topologyModefield has the same name and type name as before the refactoring, but is structurally distinct and so could not be correctly deserialized.To avoid this, and to avoid potential other confusions with the previous enum
TopologyMode, the new class has been renamed toTopologyTypeSetand methods and variable names have been updated accordingly.Possible Drawbacks
None expected
Documentation Notes
Release Notes
This change is