Fix VBL setters to always return arrays of valid polygons. #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `getTokenVBL()` now always returns an array and never an empty string. - `getVBL()`, `getTokenVBL()`, `getHillVBL()`, and `getPitVBL()` now return an empty array where previously they returned a singleton array containing an invalid empty polygon.
Phergus
approved these changes
Jan 15, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #2763
Description of the Change
getTokenVBL()now always returns an array and never an empty string.getVBL(),getTokenVBL(),getHillVBL(), andgetPitVBL()now return an empty array where previously theyreturned a singleton array containing an invalid empty polygon.
Possible Drawbacks
Documentation Notes
N/A
Release Notes
set*VBL()would error out when passed empty VBL from a previousget*VBL()call.This change is