Fire TokensAdded / ZoneAdded when handling PutZoneMsg #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were firing `TokensRemoved` / `ZoneRemoved`, which in particular causes Lib:tokens to be removed from the library manager. They weren't being added back until another interaction required them.
cwisniew
approved these changes
Apr 12, 2023
kwvanderlinde
deleted the
bugfix/3908-lib-tokens-are-removed-after-cell-type-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix or Enhancement
and possibly closure of the pull request if it is not provided after this request.
Identify the Bug or Feature request
Fixes #3908
Description of the Change
This fixes an error introduced in PR #3749. In
ServerMessageHandler, we were firingTokensRemoved/ZoneRemovedwhereTokensAdded/ZoneAddedis expected. The analogous logic inClientMessageHandlerhad this correct already.In particular this was causing Lib:tokens to be removed from the library manager in cases such as cell type changes.
Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
N/A (fixes a new bug)
This change is