Handle nullabilty when converting LookupTable to DTO #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each reference field in `LookupTable` and `LookupEntry` is marked as `@Nullable` or `@Nonnull` for clarity. `@Nonnull` is enforced for deserialized fields in `readResolve()`, with corresponding `null` checks in accessors being removed. Several `Boolean` accessors have been changed to `boolean` since nullability for these fields in an internal detail. In `toDto()`/`fromDto()`, all `@Nullable` fields are checked first whether a value exists prior to converting. The `visible` and `allowLookup` flags are now included in the copy constructor so that copied tables have the same flags set.
cwisniew
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #3913
Description of the Change
Each reference field in
LookupTableandLookupEntryis marked as@Nullableor@Nonnullfor clarity.@Nonnullis enforced for deserialized fields inreadResolve(), with correspondingnullchecks in accessors being removed. SeveralBooleanaccessors have been changed tobooleansince nullability for these fields in an internal detail.In
toDto()/fromDto(), all@Nullablefields are checked first whether a value exists prior to converting.The
visibleandallowLookupflags are now included in the copy constructor so that copied tables have the same flags set.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is