Fix for MapTool registry errors in 1.13.0 #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4035 4035
Description of the Change
The code had been retrieving the body of the response first to check if it was empty and, if not, later on retrieving it again to parse it. This was working in previous versions of okhttp3 but no longer works, and an
IllegalStateExceptionis thrown. I have modified the code to retrieve the body only once and use that result for the empty check and parsing.I have also captured and dealt with all exceptions by displaying an error message dialog and returning from the method correctly to handle it more gracefully (currently, you can end up in a state when you can not continue and have to close MapTool).
Possible Drawbacks
There should be none.
Documentation Notes
Fix problems that can arise when fetching information from the MapTool server registry.
Release Notes
This change is