Remove campaign export and all related code #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dialog itself, the supporting functionality in `CampaignExport`, and the version that gets passed around to ultimately end up with `CampaignExport`. The current MapTool version and campaign version will still be written out.
kwvanderlinde
changed the title
cwisniew
approved these changes
May 16, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #4047
Description of the Change
This removes the various bits that make up the campaign export feature. The menu item under File > Export is removed, and the code for the dialog and export itself has been removed.
This PR does nothing with regards to
ModelVersionManageras that turned out to be more subtle than expected.Possible Drawbacks
For those cases that still worked, it won't be as convenient to downgrade a campaign all the way back to 1.3/1.4/1.5 anymore.
Documentation Notes
N/A? Documentation around campaign exports can removed.
Release Notes
This change is