Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NPE on image list when adding bars #4097

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented May 30, 2023

Identify the Bug or Feature request

Fixes #4093

Description of the Change

There were a few errors with the bars settings dialog box.

  1. Images were not able to be added because the model being used for the JList did not support it
  2. The scroll panel had no name so a NPE was generated when trying to scroll to the latest image
  3. The bar type and side combo boxes were internationalised strings, so when trying to compare the results bars were failing to be added.

This is just a short-term fix, we need to replace this dialog in the process of replacing others in campaign properties.

Possible Drawbacks

The dialog isn't any less flakey than it was in 1.12
Its probably going to cause me to shed a great deal of tears when merging with #4084 but it is what it is...

Documentation Notes

  • Fixed problems adding token bars

Release Notes

  • Fixed problems adding token bars

This change is Reviewable

@cwisniew cwisniew changed the title Fix for NPE on image list Fix for NPE on image list when adding bars May 30, 2023
@cwisniew cwisniew added the bug label May 30, 2023
@thelsing
Copy link
Collaborator

LGTM

@cwisniew cwisniew merged commit b912e6a into RPTools:release-1.13 Jun 2, 2023
@cwisniew cwisniew deleted the fix-4093 branch June 2, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants