Revert "Add unique light sources on tokens, and macros for manipulating them." #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which other things? The problem with the Edit Token dialog is not due to the change you're reverting. |
|
#4375 fixes the dialog |
|
hopefully other changes to the token will also work. Had trouble with things like setting halos. |
|
For something like that it's possible you need to refresh your protobuf codegen. |
|
@bubblobill Can you confirm whether things work for you now on the latest |
|
Just had a quick test. The bits I was playing with previously are behaving in the current develop |
bubblobill
deleted the
revert-4356-feature/331-unique-lights-on-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4356
Cannot open edit token dialog and a few other things seem a bit squirly.
Please take this back
This change is