Fix handling of assert failures in event handlers #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `catch` blocks for `AssertFunctionException` whereever `AbortFunctionException` is being caught. There were only two remaining places, which were in the event handling code. Also `AssertFunctionException` no longer extends `ParameterException` as it is not necessarily an indicator of parameter validation. No functional difference as `ParameterExecption` is not caught exlicitly anywhere.
thelsing
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4391
Description of the Change
This adds
catchblocks forAssertFunctionExceptionwhereeverAbortFunctionExceptionis being caught. There were only two remaining places, which were in the event macro code.Also
AssertFunctionExceptionno longer extendsParameterExceptionas it is not necessarily an indicator of parameter validation. No functional difference asParameterExecptionis not caught exlicitly anywhere.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is