Consistently add light options to Campaign Properties #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating over the segments of a light source, instead of separate variables to track previous state we now have a map that maintains all properties from the previous segment. In the loop we just update the map, and then have a uniform way to output them to the `StringBuilder`. The order now matches documentation: shape+arc/offset, owner/gm, radius+colour+lumens. Parameters are only included if different from the previous occurrence (or from the default for the first occurrence).
Factor out the common shape and distance output rather than repeating the code for all shapes. Also coaelesce the shapes that have no special logic.
kwvanderlinde
force-pushed
the
feature/4059-be-consistent-about-light-parameters
branch
from
d62edfc to
29bb68d
Compare
cwisniew
approved these changes
Dec 1, 2023
kwvanderlinde
deleted the
feature/4059-be-consistent-about-light-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4059
Description of the Change
The light panel update is modified to consistently handle any parameters to a light segment. It is now trivial to get everything rendered in a consistent order (shape/arc/offset, gm/owner, radius/colour/lumens) and exactly when needed.
In addition to showing offset only if needed, it will also be included when set to zero if a previous segment had a non-zero offset. Previously this was not done and so the rendered string would not accurately describe a light with a zero offset.
The sight panel update was also modified, but just to factor out a bit of common functionality.
Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
conekeyword.This change is