Add UI for defining unique lights #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New `LightSyntax` defines the syntax of lights, handling both parsing and rendering as strings. The logic is essentially what it was in `CampaignPropertiesDialog`, but has been decomposed so that lights can be used without or without categories. In the same vein, `SightSyntax` defines the syntax of sights, though not extra functionality has been built into it.
This saves some horizontal space in the common case of using the default lumens value.
Disable unique light sources panel for non-GMs; player can still see the definitions, no harm in that. Some layout changes were necessary to prevent the portrait etc. from shrinking too much. The terrain modifier input width was fixed as well.
kwvanderlinde
changed the title
cwisniew
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #3087
Improves #331 / #4356
Description of the Change
Adds a new text box to the Edit Token dialog where light sources can be added. The syntax is the same as in the Campaign Properties dialog, except that no categories are supported. The text box is only enabled when a GM is editing the token, in keeping with the trusted requirements of the macro functions.
Some minor attached changes:
Before (1.14):
After:
Possible Drawbacks
Config tabs is getting more crowded. No good place to put help text as in Campaign Properties
Documentation Notes
It is possible to add unique lights to a token using the Edit Token dialog, Config tab. The syntax is the same as for campaign properties, except that categories cannot be used.
Release Notes
This change is