Refactor EditTokenDialog.action.hero.statBlockRTextScroll i18n key. #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1122,7 +1122,7 @@ | |||
| <properties> | |||
| <actionCommand value="Find"/> | |||
| <name value="textStatblockSearchButton"/> | |||
| <text resource-bundle="net/rptools/maptool/language/i18n" key="EditTokenDialog.action.hero.statBlockRTextScroll"/> | |||
| <text resource-bundle="net/rptools/maptool/language/i18n" key="EditTokenDialog.action.hero.statBlockRTextScroll.label"/> | |||
There was a problem hiding this comment.
Forgot to change statBlockRTextScroll to statBlockSearch 🙂
There was a problem hiding this comment.
oops, should be fixed now
kwvanderlinde
approved these changes
Dec 16, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4560
Description of the Change
The i18n key EditTokenDialog.action.hero.statBlockRTextScroll provides no context to translators for the value find
Change EditTokenDialog.action.hero.statBlockRTextScroll to EditTokenDialog.button.hero.statBlockSearch.label
Possible Drawbacks
Should be none.
Release Notes
This change is