Better encapsulated version of Zone.clearDrawables() #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a `Layer` parameter is supported now instead of a `List<>`. The previous approach relied on `.clear()`ing the parameter list to effect a change on the `Zone`, which is bad news.
cwisniew
approved these changes
Dec 30, 2023
kwvanderlinde
deleted the
bugfix/4585-clear-drawables-unsupported-operation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4585
Description of the Change
Only a
Layerparameter is supported now instead of aList<>. The previous approach relied on.clear()ing the parameter list - previously returned bygetDrawnElements()- to effect a change on theZone, which is bad news and not supported by a prior change to returning unmodifiable lists.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
N/A
This change is