Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMacro function fix fix #4605

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Jan 2, 2024

Requirements for Contributing a Bug Fix or Enhancement

#4583 introduced new errors #4582
Macro calls without parameters were being excluded in the branching path.

Identify the Bug or Feature request

fixes #4582

Description of the Change

Removed incorrect branching in metamacro functions where calls without parameters were being bypassed.

Possible Drawbacks

none

Documentation Notes

Test campaign.

  • Token has macros for all metamacro functions with all variations of parameters.
  • Campaign and GM panels have macros for all metamacro functions for each parameter set that contains an id.

metaMacroTest.cmpgn.zip

Release Notes

n/a


This change is Reviewable

@cwisniew cwisniew added the bug label Jan 2, 2024
@cwisniew cwisniew added this pull request to the merge queue Jan 2, 2024
Merged via the queue into RPTools:develop with commit efc31d9 Jan 2, 2024
4 checks passed
@bubblobill bubblobill deleted the macrofunction_fix branch January 23, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: metamacro functions producing Java errors
2 participants