build-docker.sh updated to allow for empty PIGEN_DOCKER_OPTS #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecified during docker build
|
What impact does this PR have? As far as I can tell, there's no difference between a variable being empty and it being unset, in this case. |
|
Hello! Fair point, I guess they are equivalent in that sense - I could've worded the initial commit a bit better. The intent of this PR was to still allow for a default docker build should a user not specify any additional PIGEN_DOCKER_OPTS. |
|
I guess I don't understand what you mean by 'allow' in this sense. It still works whether or not the user sets the variable or not as is, right? |
|
It did not - when I pulled the repo the other day and ran ./build-docker.sh for my project I received the following:
So I added a statement in that script to set PIGEN_DOCKER_OPTS to a value of "" if unspecified by the user. |
|
Oh right, look like the author of this script passes the |
Aalococo
pushed a commit
to ConsolinnoEnergy/pi-gen
that referenced
this pull request
Jan 27, 2022
update: WPA_COUNTRY feature: menderize added Update Dockerfile Revert "Update Dockerfile" This reverts commit 44edfed. feature: add nmap package feature: added menderize script git: add mender_work to gitignore update: menderize script fixed and added to readme fix: menderize Revert "feature: menderize added" This reverts commit 0b0b559. update: add build mendercontainer fix: chmod changed update: motd sudo ping update: motd update: added leaflet cli to image fix: remove sudo from motd update: remove ping from motd fix: typo in ssh command fix: ssh folder refactor: mende_work to dockerignore feature: Nymea stage with updated nymea package list update: menderize script Customized mender.conf creation script is now used refactor: motd fix: package list is now updated after new repos are added feature: update nymea added nymea experimental repo and updated packagelist feature: syslog forward deactivted journalctl will no longer forward logs to syslog(safes discspace) feature: leaflet-hotspot manager added feature: Img Version number added feature: menderize exit codes added return errors to exits in script fix: naming feature: moved menderize script to Imagebuilder feature: identity added feature: add Image Version to motd refactor: img name changed feature: InstalledPackages.list added update: version string feature: motd update feature: leaflet.info added feature: filename changed feature: added IMG_VERSION as input for build.sh refactor: added comments feature: added image version reafactor: removed breaking comments fix: leaflet.info added Update release notes Added PIGEN_DOCKER_OPTS to build-docker.sh (RPi-Distro#521) Update Beginner's Guide download link Added simple catch for default case in which PIGEN_DOCKER_OPTS is unspecified during docker build (RPi-Distro#522) Fix: update dependencies (RPi-Distro#526) Copy debootstrap.log on failure Fix broken imagetool.sh --mount (RPi-Distro#529) fix: leaflet.info feature: image name updated Revert "feature: image name updated" This reverts commit e436240. update: imgname in config refactor: commented feature: moved package list to own stage feature: updated Image Info file update: info and releaseontes fix: finalize stage feature: added wifi ip to hotspot settings refactor: motd.sh feature: leaf user no password refactor: convert Image version format in info file ci: removed gitlab yml feature: leaflet-hotspot now shows more status info fix: removed various bugs in Hotspot script docs: update release notes update: .info file updated ci: Info file update feature: added openvpn package feature: network settings to data partition fix: fix local config for leaflet hotspot fix: typo in hotspot feature: hotspot now has last 4 digits of serial number feature: networkmanager WIFI only if password was set feature: add hostname change to hotspot tool feature: hostname and hotspot refactor refactor: updated Hotspot and Network stage feature: leaflet-configure added feauter: leaflet-configure fixed fix: motd not using base software anymore feature: added python pip3 package feature: skipping nymea stage fix: leaflet-wizzard password to json fix: change owner of .ssh folder feature: added network manager feature: purge conflicts with network manager fixed: hotspot service after network manager remove: root password feature: remove leaf user, only ssh key fix: removed SKIPs feature: no hotspot at default feature: leaflet-network Leaflet-hotpsot is now named leaflet-network and holds options for wired connection fix: typo in leaflet-network feature: hems and cems test fix: typo feature: update nymea package list feature: added cems stage update .info file update leaflet-network to 0.2 feature: added live repo
SRaus
pushed a commit
to analogdevicesinc/adi-kuiper-gen
that referenced
this pull request
Feb 28, 2022
…pecified during docker build (RPi-Distro#522)
SRaus
pushed a commit
to analogdevicesinc/adi-kuiper-gen
that referenced
this pull request
Mar 1, 2022
…pecified during docker build (RPi-Distro#522)
scuciurean
pushed a commit
to analogdevicesinc/adi-kuiper-gen
that referenced
this pull request
Mar 23, 2022
…pecified during docker build (RPi-Distro#522) (cherry picked from commit 54e1bb4)
wandering-andy
pushed a commit
to wandering-andy/pi-gen
that referenced
this pull request
Oct 15, 2023
…pecified during docker build (RPi-Distro#522)
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
…pecified during docker build (RPi-Distro#522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple catch for default case in which PIGEN_DOCKER_OPTS is unspecified during docker build