Fix LIKWID_VERSION and LIKWID_COMMIT macros in likwid.h not being set correctly during installation #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. It has to wait until the next major release as it changes the main header |
|
I see, thanks anyway for the quick response :) |
|
Alternatively, we could probably also do it the other way around and only adjust the expected names in the Makefile, right? Would that be better @TomTheBear ? |
|
Changing the names in the Makefile is probably a better approach. As long as no change happens to |
… correctly during installation
OoJJBoO
force-pushed
the
fix_likwid_h_version_macro
branch
from
e3f2db6 to
8e5090f
Compare
|
Just replaced the first commit, this time only modifying the Makefile. Looks to also work just fine this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with different versions, I noticed that the
LIKWID_VERSIONandLIKWID_COMMITmacros are currently not set correctly during the installation step, because there are some discrepancies between the naming used inlikwid.hand the scheme the correspondingsedcommand in the Makefile expects.Using the changes in this commit, the insertion should work as originally intended.