fix: support Query:iter_matches changes in upstream neovim
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neovim's `Query:iter_matches` function now returns a list of Nodes for each match in nightly. Previously the `iter_matches` function only returned the *last* node. To get that previous behavior we just pull the last node out of the returned list of nodes. According to `:h news.txt`, `Query:iter_matches` added a backwards compatibility option (`all=false`), but the intent is to remove it in a future release — thus it's better to rip the band-aid off now instead of fighting this again later on. See neovim/neovim@6913c5e.
|
@simonmandlik - Can this be merged? |
|
This is not a question for me — I didn't write a single line of code of the core of the plugin, only provided julia support :) Perhaps @RRethy ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from the body of the commit:
TL;DR:
Neovim upstream recently changed the return from
Query:iter_matchesand this adds a simple shim to support it for current nightly users. It should have the exact same behavior as what was previously used AFAIK.